Change retention of @Property annotation from SOURCE to CLASS:
#2646
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_854091995
branch
from
d289c7d to
a814105
Compare
copybara-service
bot
changed the title
@Property annotation from SOURCE to CLASS:
copybara-service
bot
force-pushed
the
test_854091995
branch
from
a814105 to
15bd46b
Compare
- it makes it consistent with `@ObjectiveCName` annotation which is also `CLASS`, - it's necessary for J2CL to read this annotation from `.class` files. PiperOrigin-RevId: 855210368
copybara-service
bot
force-pushed
the
test_854091995
branch
from
15bd46b to
97c4fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change retention of
@Propertyannotation fromSOURCEtoCLASS:@ObjectiveCNameannotation which is alsoCLASS,.classfiles.